Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid" check for Mappings #259

Open
romuald opened this issue Apr 4, 2016 · 0 comments
Open

"Invalid" check for Mappings #259

romuald opened this issue Apr 4, 2016 · 0 comments

Comments

@romuald
Copy link

romuald commented Apr 4, 2016

Small issue with dict-like mappings

In the Mapping _validate method

Colander is checking if there is an "items" attribute

However python (2) checks if there is a keys attribute instead : https://github.com/python/cpython/blob/2.7/Objects/dictobject.c#L1475


Note that fixing by replacing items by keys this might break some existing validation. I'm just submitting this as a possible issue (maybe simply try to use dict(value)?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant