Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Icon also for FileBrowse / FileSaveAs etc. window #1685

Closed
ncotrb opened this issue Jul 15, 2019 · 6 comments
Closed

Custom Icon also for FileBrowse / FileSaveAs etc. window #1685

ncotrb opened this issue Jul 15, 2019 · 6 comments
Labels
Bug Something's not right Done - Install Dev Build (see docs for how) See https://docs.pysimplegui.com/en/latest/documentation/installing_licensing/upgrading/

Comments

@ncotrb
Copy link

ncotrb commented Jul 15, 2019

Type of Issues (Enhancement, Error, Bug, Question)

Question

Operating System

Windows 10

Python version

3.7.3

PySimpleGUI Port and Version

PySimpleGUI-TK 4.0.0

Code or partial code causing the problem

Hello Mike, I have the following question. I have successfully given the main window its own icon, but when I use the file open window / folder open window etc., the standard feather icon of TK is displayed. Is there a workaround / parameter for this? =)

import PySimpleGUI as sg

layout = [[sg.SaveAs("SaveAs"),
           sg.FileBrowse("FileBrowse"),
           sg.FilesBrowse("FilesBrowse"),
           sg.FileSaveAs("FileSaveAs"),
           sg.FolderBrowse("FolderBrowse")]]

window = sg.Window("Custom Icon Test", layout, icon="star.ico")

while True:
    event, values = window.Read()
    if event == None:
        break

window.Close()

staricon

Kind regards, Nico

@MikeTheWatchGuy MikeTheWatchGuy added the Bug Something's not right label Jul 15, 2019
@MikeTheWatchGuy
Copy link
Collaborator

Yea, that don't seem right now does it.

@MikeTheWatchGuy MikeTheWatchGuy added the Done - Install Dev Build (see docs for how) See https://docs.pysimplegui.com/en/latest/documentation/installing_licensing/upgrading/ label Jul 15, 2019
@MikeTheWatchGuy
Copy link
Collaborator

Fixed.

Get a new PySimpleGUI.py file from the GitHub and place into your application's folder. I tested it using your test harness. I really appreciate you coding that up. Very helpful and we got to a quicker fix as a result.

image

@ncotrb
Copy link
Author

ncotrb commented Jul 16, 2019

Yeeeeah.... Great! Thank You very much! This saves me a lot of resource hacking, which is certainly not intended.
I am sure that you have not only made me happy, but also many others with this bug fix =)

@PySimpleGUI
Copy link
Owner

Released to PyPI as release 4.1 so you can delete any local copies and use the new pip installed version

@rjungbeck
Copy link

Do we have that problem again (in 4.34.0) on Windows 10/64 with Tkinter.

I see the Python Icon in the FileOpen FileSave dialogs and in the OneLineProgressMeter, although I have set a different icon for the main window.

@jason990420
Copy link
Collaborator

New post please if you have new issue, also issue form required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something's not right Done - Install Dev Build (see docs for how) See https://docs.pysimplegui.com/en/latest/documentation/installing_licensing/upgrading/
Projects
None yet
Development

No branches or pull requests

5 participants