Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to skip passing --interpreter option when building editable wheels via pep517 backend #1896

Open
messense opened this issue Dec 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@messense
Copy link
Member

PEP 517 build backend uses build isolation by default and in some cases for example when using Poetry to manage a pyo3 module as a path dependency, build isolation can't be disabled.

Thus the --interpreter/-i option we pass to maturin pep517 build-wheel varies among executions because it points to a random python interpreter in /tmp. This causes unnecessary rebuild of pyo3 crate due to PYO3_PYTHON env var value changes.

I think at least for editable wheels we could try not passing a random --interpreter path, making it possible to better utilize cache. It should be an opt-in option of course.

@messense messense added the enhancement New feature or request label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant