New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Comments returned for PullRequest #59
Comments
Hello! I confirm that the following code exhibits the same issue:
It prints:
This last line calls API https://api.github.com/repos/jacquev6/PyGithub/pulls/57/comments, as documented in http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request, but the API returns an empty list. I've just managed to get the comments by calling https://api.github.com/repos/jacquev6/PyGithub/issues/57/comments instead. The issue must be on Github's side. As a temporary work-around, you can use the following code to do as if the pull request is an issue, and call the other API:
Right now, I have not enough time to take care of this problem, but if it's still here at the beginning of September, I will contact Github and/or patch PyGithub. Enjoy, |
To enhance the workaround a bit, you can do this to determine if an issue is a PR or not (because all PRs are issues, too):
|
Thank you! Will use this as a workaround. |
I've just contacted Github for this issue. |
And here is the reply I received from Github:
So, this is coherent with what we can see here: #57, as Anyway, this is misleading, so I will add two methods named |
I've just pushed the new methods on https://github.com/jacquev6/PyGithub/tree/develop. I close the issue because I feel it's solved. @nixoz2k7, do not hesitate to re-open it if you still have a problem with what has been said. |
Thank you so much ;) Thank you again. |
Hello, here is the problem.
No Comments returned. But comments count showing proper value.
p = z.pulls[1]
p
OUTPUT: <github.PullRequest.PullRequest object at 0x104e6e5d0>
OUTPUT: u'\u041d\u0435 \u043f\u0440\u0438\u043d\u0438\u043c\u0430\u0442\u044c =)'
p.comments
OUTPUT: 1
p.get_comments()
OUTPUT: <github.PaginatedList.PaginatedList instance at 0x104cd6c68>
list(p.get_comments())
OUTPUT: []
Any ideas ?
The text was updated successfully, but these errors were encountered: