Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #430

Closed
garrettheel opened this issue Aug 3, 2016 · 8 comments
Closed

New release #430

garrettheel opened this issue Aug 3, 2016 · 8 comments

Comments

@garrettheel
Copy link

garrettheel commented Aug 3, 2016

Hi, can you please publish a new release. add_membership is currently broken in the latest release due to this changeset not being included:

a06b5ec#diff-20d5f1aeabe90232d524e590cc5d1972

@babineaum
Copy link
Contributor

👍

@babineaum
Copy link
Contributor

I would love to have this cut off master, or wait till we can get a few of the smaller PRs in.

@jakirkham
Copy link

Dup of issue ( #391 ).

@babineaum
Copy link
Contributor

Great that its a dupe... Maybe if we will the issues up we can get a release?

@jzelinskie
Copy link
Contributor

Hey,

I'd love to get another release out, but the build appears to be broken by the last commit.
@jayfk is there an ETA on a fix for this? Next time you should really open a pull request, so that the head of master is always able to be deployed.

@jayfk
Copy link
Contributor

jayfk commented Aug 9, 2016

@jzelinskie Sorry, I've tested it locally but forgot to add the changes to the replay data to the commit. For whatever reason they weren't serializable.

Fixed in 9134aa2, build is green again.

Have you got a chance to think about my comment in #391 (comment)?

It's a bit of more work right now, but saves you a lot of time for each new release in the future.

@babineaum
Copy link
Contributor

SWEET! thanks guys! (and ladies if involved)

@jayfk
Copy link
Contributor

jayfk commented Aug 12, 2016

I'm happy to announce that PyGithub 1.27.1 is out :)

@jayfk jayfk closed this as completed Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants