Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get status of checks on a Pull Request #1621

Closed
ChaiBapchya opened this issue Jul 26, 2020 · 12 comments
Closed

Get status of checks on a Pull Request #1621

ChaiBapchya opened this issue Jul 26, 2020 · 12 comments

Comments

@ChaiBapchya
Copy link

Currently, PyGithub API doesn't allow to check for status of the checks run on a PR.

For e.g. in case of a PR apache/mxnet#18785
There are 12 status checks.
There should be an API that exposes the status of each of those 12 checks or overall status of that PR.

@ChaiBapchya
Copy link
Author

Related issue #1063

@wrecker
Copy link
Contributor

wrecker commented Aug 2, 2020

@s-t-e-v-e-n-k @sfdye I have made significant progress on implementing the Github Checks API. For now I have most of the READ actions implemented based on this: https://docs.github.com/en/rest/reference/checks

  • CheckSuite
  • CheckRun
  • CheckRunOutput
  • CheckRunAnnotation
  • GithubApp

Whats your preferred way of sending PRs? One big monolith PR (with individual commits) or split PRs?

@sfdye
Copy link
Member

sfdye commented Aug 3, 2020

Of course individual PR is easier to review, but both are welcome

wrecker added a commit to wrecker/PyGithub that referenced this issue Aug 3, 2020
@wrecker
Copy link
Contributor

wrecker commented Aug 3, 2020

@sfdye The first of the PRs is in.

wrecker added a commit to wrecker/PyGithub that referenced this issue Aug 9, 2020
s-t-e-v-e-n-k pushed a commit that referenced this issue Aug 9, 2020
* Add initial support for Github Apps.

Needed for #1621
wrecker added a commit to wrecker/PyGithub that referenced this issue Aug 9, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 4, 2020
@stale stale bot closed this as completed Oct 11, 2020
@cristianmtr
Copy link

Is this available? I can't find it

@ChaiBapchya
Copy link
Author

Don't think its supported yet. There was some PR opened on aug 2 but got closed. so ya.. we're all waiting :)

@Croydon
Copy link

Croydon commented Nov 18, 2020

Please re-ope this then :)

@sfdye sfdye reopened this Nov 18, 2020
@stale stale bot removed the stale label Nov 18, 2020
dhruvmanila pushed a commit to dhruvmanila/PyGithub that referenced this issue Nov 25, 2020
dhruvmanila pushed a commit to dhruvmanila/PyGithub that referenced this issue Nov 26, 2020
s-t-e-v-e-n-k pushed a commit that referenced this issue Nov 30, 2020
* Add initial support for Check Suites
* Add API call detail in CheckSuite.rerequest
* Update Accept header with general instead of preview
* Add 'get check runs' endpoint for CheckSuite with stubs
* Add create check suite endpoint with stub
* Update CheckSuite tests with creat check suite endpoint
* Add update check suites preferences endpoint
* Add repository preferences object and stub file
* Add update check suite preferences tests

Needed for #1621

Co-authored-by: Raju Subramanian <coder@mahesh.net>
@Seluj78
Copy link

Seluj78 commented Dec 2, 2020

Hey ! If you upgrade to 1.54, check suite and runs are supported !

If you want an example, I use it here: AFPy/PyDocTeur#47

@ChaiBapchya
Copy link
Author

While I can see check-suites works with 1.54
I can see that the number returned is incorrect
For example:
For this commit: apache/mxnet@232538f
There were 14 checks made.
But the result returned by the api for this specific commit is:

>>> commit
Commit(sha="232538f4f4f704fd5d01b97b66655bab5393942b")
>>> for a in cs:
...      print(a)
...
CheckSuite(url="https://api.github.com/repos/apache/incubator-mxnet/check-suites/1063117829", id=1063117829)
CheckSuite(url="https://api.github.com/repos/apache/incubator-mxnet/check-suites/1064967098", id=1064967098)

@s-t-e-v-e-n-k
Copy link
Collaborator

That is a Check Suite (That is, a suite of checks), which contains a number of Check Runs, and you'll probably find each CheckSuite has 7 CheckRuns.

@ChaiBapchya
Copy link
Author

Closing since the issue is resolved! Thanks everyone involved in this issue & corresponding PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants