Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for out-of-date basis sets #261

Open
DanHickstein opened this issue Jul 29, 2019 · 0 comments
Open

Check for out-of-date basis sets #261

DanHickstein opened this issue Jul 29, 2019 · 0 comments

Comments

@DanHickstein
Copy link
Member

DanHickstein commented Jul 29, 2019

This is a placeholder issue, following the discussion here: #260 (comment)

Basically, PyAbel will currently load basis sets without checking when they were generated. If a user generates basis sets with an old version of PyAbel, there is the possibility that these basis sets will be incompatible with a later version. Alternatively, the basis sets may simply be wrong. We could catch a bug in one of the basis set generation algorithms and have no way of pushing this improvement to users who have a huge stash of legacy basis set files.

One approach would be to check the date modified of the basis set files and make sure that this date is more recent than the date of the basex.py (or other method) file. This would ensure that the basis sets were always up to date. For users who intentionally want to use old basis sets (for example, they have generated ones that take a very long time to generate, and are comfortable that no improvements have been made to the basis set generation code), we could allow a keyword argument to be passed to the transform methods that allows old basis sets to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant