Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: give users the option between dark theme and light theme #205

Open
elimisteve opened this issue Jun 20, 2018 · 2 comments

Comments

@elimisteve
Copy link
Contributor

elimisteve commented Jun 20, 2018

1 developer suggested this, and 1-2 users have since requested.

And 2 people have said they hate the (current) dark theme.

@elimisteve elimisteve changed the title Give users the option: dark theme or light theme Feature request: give users the option between dark theme and light theme Jun 20, 2018
@4xdk
Copy link
Collaborator

4xdk commented Jul 21, 2018

I like the dark theme personally, but I think it's a good idea.
Will look into this if that's ok.

Actually, this may be a good moment to suggest that we switch to using SASS or LESS instead of writing pure CSS. I won't get into details here as this article does a better than me at explaining why https://alistapart.com/article/why-sass

@4xdk
Copy link
Collaborator

4xdk commented Jul 21, 2018

Switched to SCSS in here - branch. It was pretty quick n easy, thanks to the create-react-app docs. Followed almost to the letter (skipped changing npm run build scripts).

Couldn't spot any issues, except just now realized the branch is bit behind develop branch - will pull tomorrow.

The nice thing about it is that no file contents needed to change, just renamed from .css to .scss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants