Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light/Dark mode toggle missing in vertical navbar #50

Open
FoxtrotSierra6829 opened this issue Nov 18, 2023 · 4 comments
Open

Light/Dark mode toggle missing in vertical navbar #50

FoxtrotSierra6829 opened this issue Nov 18, 2023 · 4 comments

Comments

@FoxtrotSierra6829
Copy link
Collaborator

grafik
Horizontal navbar has light/dark mode toggle

grafik
Vertical navbar does not have light/dark mode toggle

@PupoSDC
Copy link
Owner

PupoSDC commented Nov 18, 2023

The idea here is to add a settings tab to the vertical navbar to control these and other things. The horizontal and vertical navbar are not 1 to 1 equivalents

@FoxtrotSierra6829
Copy link
Collaborator Author

IMO the light/dark mode toggle should be top level though for quick access as this is likely a setting which is going to be changed more frequently.
On that note, maybe we can make this a three way switch: light, dark, system

@PupoSDC PupoSDC assigned PupoSDC and unassigned PupoSDC Nov 19, 2023
@PupoSDC
Copy link
Owner

PupoSDC commented Nov 24, 2023

This does not necessarily close the issue, but here is the settings screen I had envisioned.

#56

@PupoSDC
Copy link
Owner

PupoSDC commented Jan 17, 2024

Light dark button is now more prominently present

#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants