Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic recorded even with Record not enabled #2005

Open
wabiloo opened this issue Apr 24, 2024 · 4 comments
Open

Traffic recorded even with Record not enabled #2005

wabiloo opened this issue Apr 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@wabiloo
Copy link

wabiloo commented Apr 24, 2024

Description

I have noticed that if I have the proxy overridden, and scripting enabled which applies to some URLs, those URLs will be modified and recorded even if the "Record" button is not activated.

Is that normal?

@wabiloo wabiloo added the question Further information is requested label Apr 24, 2024
@NghiaTranUIT
Copy link
Member

yes, it's normal because the Proxy Overriden is enabled, it means your traffic is still going through Proxyman, which can be modified by the Scripting tool.

The Record Button just toggles whether or not it should be recorded and shows in the Main Table View.

@wabiloo
Copy link
Author

wabiloo commented Apr 24, 2024

But that's what I'm saying. It appears in the Main Table View (when modified by scripting) even if I am not recording...

@NghiaTranUIT
Copy link
Member

so, it's a bug. Let me investigate and fix it 👍

@NghiaTranUIT NghiaTranUIT self-assigned this Apr 25, 2024
@NghiaTranUIT NghiaTranUIT added the bug Something isn't working label Apr 25, 2024
@NghiaTranUIT NghiaTranUIT added this to the Proxyman 5.3.0 milestone Apr 25, 2024
@NghiaTranUIT
Copy link
Member

@wabiloo I decided to keep this current logic because if we ignore all requests, which is modified by debugging tools, it will conflict with another useful case:

  1. Capture a bunch of requests on the main table
  2. Turn OFF the Recording button
  3. Set up some Breakpoint, Scripting tool
  4. Right-click on certain requests -> Repeat
  5. Expect: New repeated requests should be modified by Breakpoint/Scripting and also displayed on the main table.

It's useful for debugging because we can experiment while not recording any new traffic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants