Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect indexer API limits for Newznab #910

Open
1 task done
Fossil01 opened this issue Mar 28, 2022 · 5 comments
Open
1 task done

Respect indexer API limits for Newznab #910

Fossil01 opened this issue Mar 28, 2022 · 5 comments
Labels
Type: Feature Request Issue is a feature request.

Comments

@Fossil01
Copy link

Fossil01 commented Mar 28, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

Prowlarr keeps hitting API endpoints even when the user has run out of requests for the day

Describe the solution you'd like

Sonarr/Sonarr#3132 (comment)

Describe alternatives you've considered

None. Prowlarr can use the indexer API limits shown in every API response at the top of the XML response.

Anything else?

None.

AB#2857

@Fossil01 Fossil01 added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Mar 28, 2022
@bakerboy448
Copy link
Contributor

Users can set Query and Grab limits in-app on a Per Indexer basis - which is a just fine solution

this would only be applicable to Newznab Indexers

@Fossil01
Copy link
Author

It would, which covers 99% of indexers.

Users can't be trusted to set limits, or correct limits. Hence this request to respect the limits the indexer shows for that user.

@Qstick
Copy link
Contributor

Qstick commented Apr 16, 2022

It would, which covers 99% of indexers.

We support 500+ indexers, Newznab being less than 10% of them. That was bakers point

Leaving this open as we could likely set the default values for Query and Grab Limit from a call during indexer add for the Newznab engine

@Qstick Qstick changed the title Respect indexer API limits Respect indexer API limits for Newznab Apr 16, 2022
@Qstick Qstick removed the Status: Needs Triage New Issue needing triage label Apr 16, 2022
@Fossil01
Copy link
Author

We support 500+ indexers

You mean Trackers? Good Usenet indexer can be counted on two hands.

Leaving this open as we could likely set the default values for Query and Grab Limit from a call during indexer add for the Newznab engine.

That would be a good start :-)

@bakerboy448
Copy link
Contributor

Pretty sure we respect when they indicate rate limit has been reached.

Is there anything else to do here? Grabbing the limits would be a maybe as they do not exist in newznab spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Issue is a feature request.
Projects
None yet
Development

No branches or pull requests

3 participants