Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable configuration #777

Open
1 task done
onedr0p opened this issue Jan 14, 2022 · 7 comments
Open
1 task done

Environment variable configuration #777

onedr0p opened this issue Jan 14, 2022 · 7 comments
Labels
Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request.

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Jan 14, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

There's currently no support for configuring Prowlarr with environment variables.

Describe the solution you'd like

Support for setting environment variables for configuration, specifically options set in config.xml.

Precedence could probably be

  1. use environment variables, if not set...
  2. use command line arguments, if not set..
  3. read from config.xml / UI settings

Describe alternatives you've considered

N/A

Anything else?

List of environment variables (which is currently everything in config.xml) could be:

PROWLARR_LOG_LEVEL
PROWLARR_URL_BASE
PROWLARR_UPDATE_MECHANISM
PROWLARR_API_KEY
PROWLARR_BIND_ADDRESS
PROWLARR_PORT
PROWLARR_SSL_PORT
PROWLARR_ENABLE_SSL
PROWLARR_LAUNCH_BROWSER
PROWLARR_SSL_CERT_PATH
PROWLARR_SSL_CERT_PASSWORD
PROWLARR_POSTGRES_HOST
PROWLARR_POSTGRES_PORT
PROWLARR_POSTGRES_USER
PROWLARR_POSTGRES_PASSWORD
PROWLARR_POSTGRES_MAIN_DB
PROWLARR_POSTGRES_LOG_DB

AB#2364

@onedr0p onedr0p added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Jan 14, 2022
@Qstick
Copy link
Contributor

Qstick commented May 20, 2022

Does this work now after Postgres?

@onedr0p
Copy link
Contributor Author

onedr0p commented May 20, 2022

I wasn't aware any of these changes were made.

@Qstick
Copy link
Contributor

Qstick commented May 20, 2022

We use environmental variables for spinning up test instances to run Postgres integration tests during build, I just don't know if that side of it made it here from Radarr yet

@onedr0p
Copy link
Contributor Author

onedr0p commented May 20, 2022

This is an news to me, I'm probably not the best person to answer 😅 I thought this might have needed a restructuring of the way the config is handled already by changing config.xml to config.json and adding Env support for existing options.

@onedr0p
Copy link
Contributor Author

onedr0p commented May 21, 2022

Oh I found the commit on Radarr Radarr/Radarr@bd53092

I am not using Postgres to try though. This issue is more for adding support for configuring all options in the config.xml via environment variables. It's awesome to see progress started with Postgres!

@thezak48
Copy link
Contributor

thezak48 commented Feb 1, 2023

Addition to this FR, Add set auth type env

@traverseda
Copy link

traverseda commented Feb 1, 2023

Would be great if the auth env var worked with OIDC urls, if those happen in the future.

Very exciting to see this on the agenda, I think https://12factor.net/config has some good explanations on why this kind of change makes it a lot easier to deploy apps like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request.
Projects
None yet
Development

No branches or pull requests

4 participants