Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TagSelect/MultiSelect support in YML definitions [Cardigann Revision Required] #869

Open
1 task done
danimart1991 opened this issue Mar 1, 2022 · 4 comments · May be fixed by #1753
Open
1 task done

Add TagSelect/MultiSelect support in YML definitions [Cardigann Revision Required] #869

danimart1991 opened this issue Mar 1, 2022 · 4 comments · May be fixed by #1753
Labels
Type: Feature Request Issue is a feature request.

Comments

@danimart1991
Copy link

danimart1991 commented Mar 1, 2022 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

I try to modify YAML definitions to introduce multiselect/tagSelect that is already supported in Jackett and as I see in C# definitions, for example in HDBits. When I try to do this the frontend brokes, so I think that is not available in the frontend or yml parser definition.

Describe the solution you'd like

Add type tagSelect/multiSelect/multi-select like in Jackett to select more than one option in Indexer Settings.

settings:
  - name: resolutions
    type: tagSelect
    label: Search only these Video Resolutions
    selectOptions:
      2: 2160p
      3: 1080p
      4: 1080i
      5: 720p
      6: 576p
      7: 576i
      8: 480p
      9: 480i
      10: Other

image

Describe alternatives you've considered

Maybe tagSelect that is currently working in HDBits could be enough.

Anything else?

Jackett already has this settings field type. Devs could check there the functionality.

AB#2730
@danimart1991 danimart1991 added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Mar 1, 2022
@bakerboy448
Copy link
Contributor

FieldType.Select is what to use it seems and would need to be added to cardigann, and then properly parsed of course

76cabb4

@danimart1991
Copy link
Author

Select only allows one value. MultiSelect/TagSelect allows 0-n values.

Currently in HDBits, tagselect is used for codecs with these behaviour: https://github.com/Prowlarr/Prowlarr/blob/develop/src/NzbDrone.Core/Indexers/Definitions/HDBits/HDBitsSettings.cs

@Qstick Qstick added Area: Cardigann and removed Status: Needs Triage New Issue needing triage labels Apr 16, 2022
@Qstick
Copy link
Contributor

Qstick commented Apr 16, 2022

Needs Cardigann Revision

@Qstick Qstick changed the title Add TagSelect/MultiSelect support in YML definitions Add TagSelect/MultiSelect support in YML definitions [Cardigann Revision Required] Apr 16, 2022
@servarr servarr bot removed the Area: Cardigann label Apr 20, 2022
@danimart1991
Copy link
Author

Needs Cardigann Revision

Hello again.

The point is that Jackett supports multioption settings, indeed in Servarr Wiki, in the Cardigann YML definition, has the multi-option select as example of setting at line 39.
https://wiki.servarr.com/prowlarr/cardigann-yml-definition#settings

@mynameisbogdan mynameisbogdan linked a pull request Jun 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request Issue is a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: (Cardigann) Add multi-select type for settings Prowlarr/Prowlarr
3 participants
@Qstick @danimart1991 @bakerboy448