New: Use major version for installed version on Windows #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
? Based on the changes done and existing downstream, the only material change needed is what's PR'd, no? |
|
Feel incomplete to me. Also Appvername might be actually wrong upstream. |
|
I think their intention with adding AppverName was to override the default behavior of combination of name and ver. We should include that with ours. |
mynameisbogdan
requested review from
Qstick
and removed request for
Qstick and
mynameisbogdan
Qstick
reviewed
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
title
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR