New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YGGTorrent/YGGCookie search doesn't work as long as there is a category selected #1628
Comments
The problem with this is that searching automatically AND manually from radarr doesn't work anymore, which is quite bothersome, especially since YGG finally started working again recently |
Doesn't seem to be a Prowlarr issue?
There are no releases for that search string in category 2145 sub categories 2178 in the Category you selected to search which appears to have been Movie/Other https://github.com/Prowlarr/Indexers/blob/master/definitions/v9/yggtorrent.yml#L249-L256 |
The thing is, I'm using automatic sync between radarr and prowlarr, and it always worked before... |
It seems that the automatic sync between radarr and prowlarr forces Radarr to only search with the category |
Prowlarr syncs and selects the exact categories you tell it to for the app (advanced option) YGG is also anti automation and continually taking steps to break prowlarr and jackett, ban users for merely mentioning or discussing them, and continually making life as hard as possible for context. @mynameisbogdan this fall out from the category and path rework in the definition ? |
When Prowlarr performs a search using the When Prowlarr performs a keyword search with no categories, it should be making 2 requests - When Prowlarr performs a keywordless search with no categories, it should be making 2 requests - At a guess, there's an issue with Prowlarr's use of search paths categories, though I'm not sure why it's dependent on particular keywords. |
Bit of an aside. I noticed that when manually searching with 1 indexer selected all possible categories are still listed, rather than only those supported by that indexer, and indexer-specific categories (>=100000) are also missing. Implementing the latter was rejected in #722, but I couldn't see any issues for the former. Would that be something you'd be open to? |
Just a heads up, for keywords, I was using I just chose |
@ilike2burnthing this is by design in prowlarr. The paths are "pageable", meaning it stops when 0 releases are found. Thus skipping the others. The logic is simple: if aren't any results on page 1, don't fetch page 2, etc. Searching for |
So this is a bug then ? |
That makes sense if it's just pages, but cases like this are then just broken by it. |
Any news on this ? 😊 |
Same problem here. For exemple the request url (find in prowlarr.log): But, without setting the sub_category. A result is found: A tips exist for removing the sub_category automatically in the request URL ? I go to make some test. |
All its ok for me. FIX: You need to modify the "Sync Categories" in prowlarr (Setting >> app >> radarr) If you can uncheck sub category, you need to uncheck first the category (Movies) and uncheck all sub after. (dont forget to re-check the category Movies after thats) You maybe need to make the same in radarr, depend your sync setting Thats all ✌️ |
For the moment all work fine 18h~ after the trick. |
There is no 'trick', it has nothing to do with sync settings. |
prowlarr is set a full sync with radarr and sonarr. I dont talk about this sync setting. Look the sync caterogy in my screenshot. I talk about that when a say trick. |
Again, it has nothing to do with sync settings (including categories). |
Hmm okay. Sorry for my mistake. for the moment all its ok for me without sub category. How many time you would say when u say « this work for a few until sync »? |
Can someone explain what the problem is? I could do a PR if I understand what's happening and how to fix it. |
This doesn't help me I'm afraid |
The logic for Jackett is perform all relevant searches, depending on specified categories. The logic for Prowlarr (as far as I understand) is perform all relevant searches, depending on specified categories, BUT stop when the first one returns no results. So if the categories selected mean that three different searches should be performed, but the first one returns no results, the other two won't be performed. That logic makes sense when it's applied to pages (e.g. if page 1 returns no results, don't request page 2), but here we're making completely different searches, so it breaks the indexer (and likely a few others). |
Do you think you could fix it @ilike2burnthing ? |
Nope, not a chance. |
Is there a way to introduce a quick fix to allow indexers to have no category selected ? Since it seems like it works |
How about @bakerboy448 and @mynameisbogdan ? Cause this is quite the bottleneck |
There's no quick fix, this has to be done in both jackett and prowlarr in the same time which implies a lot of work since it's an another schema.json change (eg. adding If it was easy fix, trust me it would be already fixed. Also kindly, there's no need to mention me since I'm already up to date with this and it's under my radar since it affects some of my indexers too. |
Alright, sorry ! Thank you for the explanation. Has an issue been opened on Jackett too ? |
No, we're already aware of the issue. hint: me & @ilike2burnthing |
Ah I see you're contributing to both repositories ! Thanks again and good luck trying to fix this. Do let me know if you need help/testing |
I can PR a temp fix reverting the relevant parts of Prowlarr/Indexers@0bbd604. YGG would need to be maintained separately from Jackett's versions until a full fix is in place (edit: it kinda already is, because of the FlareSolverr info note). |
ygg doesn't work again sadly |
Please use one of the support channels: Discord for support/questions. |
Is there an existing issue for this?
Current Behavior
If any category is selected (for movies, haven't tried TV shows yet), no results will be returned. But with no categories, results are returned. When searching for a movie from radarr, the category
movies
is used, which used to work but doesn't anymore.Expected Behavior
That the releases are reported from YGG with or without the category.
Steps To Reproduce
Using Prowlarr
1.4.1.3243-ls575 by [linuxserver.io](https://www.linuxserver.io/)
Movie
Environment
What branch are you running?
Nightly
Trace Logs?
prowlarr.trace.log
Trace Logs have been provided as applicable. Reports may be closed if the required logs are not provided.
The text was updated successfully, but these errors were encountered: