Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Sync indexer tags to indexers in apps || Add Application Tags to Indexers #500

Open
1 task done
6cUbi57z opened this issue Sep 13, 2021 · 7 comments · May be fixed by #1332
Open
1 task done

[FEAT]: Sync indexer tags to indexers in apps || Add Application Tags to Indexers #500

6cUbi57z opened this issue Sep 13, 2021 · 7 comments · May be fixed by #1332
Labels
Type: Feature Request Issue is a feature request.

Comments

@6cUbi57z
Copy link

6cUbi57z commented Sep 13, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

I currently use indexer tags to filter the indexers used for various series. While I can add these in Prowlerr, they don't seem to sync to the apps.

Describe the solution you'd like

Tags applied in Prowlerr are automatically synced to apps.

Describe alternatives you've considered

Adding tags manually removes them on next sync.

Anything else?

Seems odd for this field to be mandatory...

AB#1579

EDIT: Corrected info on alternatives attempted. Forgot it was in "Add and remove only" sync mode so hadn't updated.

@6cUbi57z 6cUbi57z added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Sep 13, 2021
@bakerboy448 bakerboy448 added Status: Needs Triage New Issue needing triage and removed Status: Needs Triage New Issue needing triage labels Sep 27, 2021
@bakerboy448 bakerboy448 changed the title [FEAT]: Sync indexer tags to apps [FEAT]: Sync indexer tags to indexers in apps Nov 9, 2021
@bakerboy448 bakerboy448 removed the Status: Needs Triage New Issue needing triage label Dec 9, 2021
@bakerboy448 bakerboy448 changed the title [FEAT]: Sync indexer tags to indexers in apps [FEAT]: Sync indexer tags to indexers in apps || Add Application Tags to Indexers Dec 9, 2021
@santhorus
Copy link

This would be really usefull, it is getting implemented?

@FabrizioMFE
Copy link

Is there any plans on implementing this in the near future? The issue basically defeats the purpose of using full sync

@6cUbi57z 6cUbi57z linked a pull request Jan 15, 2023 that will close this issue
3 tasks
@6cUbi57z
Copy link
Author

6cUbi57z commented Jan 15, 2023

Forgot I had started looking at this. Just got an implementation working for Sonarr and Radarr and opened a PR. I don't have instances available for the other apps.

@datcactus
Copy link

datcactus commented Jan 15, 2023

Seems like a useful feature, but based on @bakerboy448 's comment in #1332 , I can't help but wonder if it's a better idea to preserve the existing tags on the app side vs syncing them over, as nice as a full sync might be. Currently on full sync the tags on the app side get deleted if there's an update, and that breaks my usual workflow of having per-indexer tags set per resource so I don't search for a non-anime piece of media on an anime-only indexer as an example.

@FabrizioMFE
Copy link

Well from what I see in that PR, it would be a toggle on the Apps settings, maybe on top of the toggle it could also be that Prowlarr just doesn't override tags unless that toggle is on?

When option on => Sync tags from Prowlarr indexers to Apps indexers
When option off => Prowlarr doesn't touch tags in Apps indexers at all

@6cUbi57z
Copy link
Author

Hmm... Good point. At the moment sync being off would default to overwriting indexers to have no tags. If the setting is off it should definitely leave them alone. That's a bug.

I'd be hesitant to have tag sync as append only. The full sync option in prowlarr is supposed to keep everything up to date AFAIK and having the setting only append then risks other future settings doing the same and "full sync" becomes far less effective. I would think if append only is wanted, the app would be set to add and remove only rather than full sync.

@CodeAnthem
Copy link

is there any update on this? happy I found this issue, I thought my prowlarr instance is buggy not syncing new tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Issue is a feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants