Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Window listing all locks with Unlock Button #84

Open
eXifreXi opened this issue Feb 18, 2023 · 6 comments
Open

Additional Window listing all locks with Unlock Button #84

eXifreXi opened this issue Feb 18, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@eXifreXi
Copy link

eXifreXi commented Feb 18, 2023

Hey there,

our team has a lot of annoying little issues with Locks. For example:

  • Whenever a user doesn't use UE to commit etc., files aren't being unlocked. Most of us (company) use the Plugin mainly for locking/reverting, but not for committing. The lock then stays and can't be undone in UE anymore, requiring the command line "git lfs unlock " or even scripts to unlock the files again.
  • Often reverting assets such as Levels doesn't work at all, as the Levels seem to be permanently loaded (even if changing to a different one) and UE simply doesn't allow reverting them. Discarding changes in Git GUIs like Source Tree won't unlock the lock either.

So all in all, we have a few ways to get stuck on locks that have to be manually unlocked via command line.

There are some third-party programs that list all locks and one could provide scripts to everyone, but overall I wondered if we can't just have a little extra SWidget (maybe even spawned from a button at the bottom right) that shows all Locks, which locked them and a button to unlock them (one by one or even all). With that, one wouldn't need to hope for a Git GUI that finally implements locks correctly, as well as not having to download yet another software.

The Git Plugin already has logic to Get All Locks and to Unlock on Commit, so I assume this is mostly a matter of creating a SWidget that runs those functions. I can have a look at it myself, but it might be a lot faster if someone who already knows the code adds this.

@mastercoms
Copy link
Member

We have been using PBSync to auto unlock unmodified files, I can add this functionality to the plugin too.

@eXifreXi
Copy link
Author

Ah, I'm trying not to use too many different programs and scripts, especially for those team members that aren't that good with all the git stuff. Would definitely be awesome to have a list of locks and some unlock feature for it exposed visually in UE (:

@mastercoms
Copy link
Member

I understand, PBSync though is specifically designed to make git easy for artists, it's a workflow tool to support the whole team.

But, I didn't mention it as a recommendation, just providing information. I'll be adding it either way since it'll be necessary for a smooth Unreal native workflow!

@eXifreXi
Copy link
Author

I'll have a look at PBSync for our artists, thanks for mentioning it (:

@eXifreXi
Copy link
Author

Also, when you do end up adding this, I would be interested in seeing the commit to try and understand how to utilize the Provider stuff for this. Because I have all the knowledge to add Editor Customizations, just not when and how to use the Provider for this.

@mastercoms mastercoms changed the title [Feature] Additional Window listing all locks with Unlock Button Additional Window listing all locks with Unlock Button Apr 26, 2023
@mastercoms mastercoms added the enhancement New feature or request label May 5, 2023
@Ciberusps
Copy link

Ciberusps commented Sep 24, 2023

Same problem( wanted to use plugin in our teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants