Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in UE5.4 #155

Open
JZWong opened this issue Apr 24, 2024 · 1 comment
Open

Does not work in UE5.4 #155

JZWong opened this issue Apr 24, 2024 · 1 comment

Comments

@JZWong
Copy link

JZWong commented Apr 24, 2024

Currently the plugin does not work in UE5.4 because the parent class of GitSourceControlChangelistState.h changed the definition of the functions

virtual const TArray<FSourceControlStateRef>& GetFilesStates() const override;
virtual const TArray<FSourceControlStateRef>& GetShelvedFilesStates() const override;
@JZWong
Copy link
Author

JZWong commented Apr 24, 2024

For a quick fix, I had to remove the & from the definition and added 2 additional virtual functions for it to compile

virtual const TArray<FSourceControlStateRef> GetFilesStates() const override;

virtual const TArray<FSourceControlStateRef> GetShelvedFilesStates() const override;
virtual int32 GetFilesStatesNum() const override;

virtual int32 GetShelvedFilesStatesNum() const override;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant