Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Container Submission Guidance #46

Open
Danulf opened this issue Dec 2, 2021 · 2 comments
Open

Write Container Submission Guidance #46

Danulf opened this issue Dec 2, 2021 · 2 comments
Assignees
Labels
guideline MONAI Deploy guidelines and design

Comments

@Danulf
Copy link
Collaborator

Danulf commented Dec 2, 2021

Writing OSS is fun but when you publish and distribute it there are guidelines often imposed upon you by the OSS that you are using and dependent upon.

Write a document that provides the guidelines we need to follow when publishing a container.

@Danulf Danulf self-assigned this Dec 2, 2021
@Danulf Danulf added the guideline MONAI Deploy guidelines and design label Dec 2, 2021
@msheller
Copy link

msheller commented Dec 2, 2021

Big +1 to this!

One core question I haven't figured out yet is whether MONAI is publishing more than just base containers. For example, would these guidelines apply to ML model developers building on MONAI?

@Danulf
Copy link
Collaborator Author

Danulf commented Dec 15, 2021

@msheller I hope we aren't publishing base containers. Instead, I hope we pull a maintained base container from someplace like NGC and simply add stuff on top within the guidance and context of those licenses. In the best case, we don't publish a container at all but simply provide the scripts to build a container for you.

Our issue here is licensing. Anytime you touch GNU licensed code, you have to "make it available" which means, in essence, yet another repository of that code (either a zip file or in our github or...). I worry that containers can bring with them a fairly deep dependency tree and we would have to analyze all the code that goes into the container to properly meet the licensing requirements. As a project, we don't have those tools developed (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guideline MONAI Deploy guidelines and design
Projects
None yet
Development

No branches or pull requests

2 participants