Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Finance needs core #84

Open
rdlauer opened this issue Dec 11, 2018 · 10 comments
Open

Personal Finance needs core #84

rdlauer opened this issue Dec 11, 2018 · 10 comments
Labels
needs additional frameworks an existing code sample that is missing one or more frameworks

Comments

@rdlauer
Copy link
Contributor

rdlauer commented Dec 11, 2018

Be sure you are basing any new framework versions on the latest iteration of this app! You can find the latest version in data/all.json or on the marketplace website.

https://play.nativescript.org/?template=play-vue&id=4JhSZz&v=49

@rdlauer rdlauer added the needs additional frameworks an existing code sample that is missing one or more frameworks label Dec 11, 2018
@tylerablake
Copy link

I'm working on adding angular to this sample.

@tylerablake
Copy link

Here's the angular addition: https://play.nativescript.org/?template=play-ng&id=zYpU71&v=8

Let me know if you see any issues.

The 3rd tab was not working on the sample so I tried to match what I thought the sample was trying to do. I'll open a different issue for that though.

@rdlauer
Copy link
Contributor Author

rdlauer commented Dec 23, 2018

Looks good! I did see one error show up on Android:

[Moto G (5) Plus]: Error in reading bitmap - java.io.FileNotFoundException: /data/data/org.nativescript.preview/files/app/images/yellow (No such file or directory)

Any ideas why the taps are so sluggish to navigate between the views?

@tylerablake
Copy link

Oh, oops, I left my Android test device at the office so I can fix that Android error on Monday.

Is it only sluggish on Android or do you notice it on iOS as well? If you are noticing it on iOS as well I can look at it tomorrow.

@rdlauer
Copy link
Contributor Author

rdlauer commented Dec 23, 2018

Yeah it seemed pretty slow on iOS as well - at least taps on the tabs aren't registering quickly? Strange.

@tylerablake
Copy link

Ok I'll look at it.

@tylerablake
Copy link

https://play.nativescript.org/?template=play-ng&id=zYpU71&v=9

Try this and let me know if it is better on your end. I didn't really notice any lag but I made the tap area a little bigger so hopefully that'll fix it for you.

@rdlauer
Copy link
Contributor Author

rdlauer commented Dec 25, 2018

I think that was it, thanks!

@tylerablake
Copy link

Perfect, I'll look into that Android issue tomorrow and post an updated link for that.

@tylerablake
Copy link

Here's the updated link: https://play.nativescript.org/?template=play-ng&id=zYpU71&v=10

I noticed the tab images were pretty small on Android so I addressed that as well.

@rdlauer rdlauer changed the title Personal Finance needs angular and core Personal Finance needs core Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs additional frameworks an existing code sample that is missing one or more frameworks
Projects
None yet
Development

No branches or pull requests

2 participants