Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDrive Allow Tenant Key Issue #617

Open
vandehey opened this issue Apr 12, 2023 · 2 comments
Open

OneDrive Allow Tenant Key Issue #617

vandehey opened this issue Apr 12, 2023 · 2 comments
Labels
⚠️ fix manifest Something isn't right & needs fixing

Comments

@vandehey
Copy link

Please provide the following information:

Name of App / Payload: ex. Firefox OR org.mozilla.firefox
com.microsoft.OneDrive

Preference key(s) needing fixing: ex. AppUpdateURL
AllowTenantList

Description of problem(s) / error(s) with listed key(s): *ex. When X preference is configured, it does not *
I'm trying to set a tenant key for AllowTenantList. When I do this, the plist preview, and what hits my mac is malformed. Here is a snip of what I'm getting w/ this JSON:

AllowTenantList

{{key}}
REDACTED
{{value}}

Description of expected behavior:
What I would expect is:

AllowTenantList


REDACTED


Applicable Documentation URL(s): If applicable ...
https://learn.microsoft.com/en-us/sharepoint/deploy-and-configure-on-macos#allowtenantlist

How are you testing / deploying your profile?: ex. manual profile install, MDM, etc.
MDM deploy via JAMF

@vandehey vandehey added the ⚠️ fix manifest Something isn't right & needs fixing label Apr 12, 2023
@rquigley-aus
Copy link

rquigley-aus commented Oct 11, 2023

I've just discovered this issue in my environment.

I believe the {{key}} and {{value}} variables are at fault, but I'm unable to put the JSON schema into a format where it will correctly output:

    <key>AllowTenantList</key>
    <dict>
      <key>ID</key>
      <true/>
    </dict>

Instead of this:

    <key>AllowTenantList</key>
    <dict>
      <key>{{key}}</key>
      <string>ID</string>
      <key>{{value}}</key>
      <true/>
    </dict>

@relgit
Copy link
Collaborator

relgit commented Oct 16, 2023

The {{key}} and {{value}} structure represents a custom dictionary in PFM and as far as I know there's no way to mark these up with the Jamf JSON-schema manifest format.

As a workaround, you could change the JSON schema to already list the keys that you are going to use, practically converting the custom dictionary to a conventional one.

For example, in your case, instead of the existing {{key}} and {{value}} properties on the AllowTenantList schema, you will have one for ID , and the markup will look somewhat like this:

 "AllowTenantList": {
    "type": "object",
    "title": "Allow Tenant List",
    "description": "This setting prevents the users from uploading files to other organizations by specifying a list of allowed tenant IDs. If you enable this setting, the user gets an error if they attempt to add an account from an organization that isn't in the allowed tenants list.",
    "links": [
        {
            "rel": "More information",
            "href": "https://docs.microsoft.com/en-us/onedrive/deploy-and-configure-on-macos#allowtenantlist"
        }
    ],
    "properties": {
        "ID": {
            "type": "boolean",
            "title": "Allow ID"
        }
    },
    "property_order": 105
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ fix manifest Something isn't right & needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants