Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show file name and size on download page #603

Open
qol3m opened this issue Apr 7, 2020 · 4 comments · May be fixed by #667
Open

Show file name and size on download page #603

qol3m opened this issue Apr 7, 2020 · 4 comments · May be fixed by #667

Comments

@qol3m
Copy link

qol3m commented Apr 7, 2020

I noticed that when I upload a .exe file, the download page does not explain at all what I am about to download.

Perhaps it should read " Download attachment (abcd.exe , 2.3MB)"

@rugk
Copy link
Member

rugk commented Apr 7, 2020

Well… currently the file name is not saved at all. 😆

This may be a good idea to be changed, indeed.

@qol3m
Copy link
Author

qol3m commented Apr 8, 2020

Hmm I guess it doesn't matter that much since the file download starts as soon as you open the link, before you click the button and "saving" just means copying it to a folder on the hard drive.

Perhaps the file size and name could be added to the button once the file has been downloaded and decrypted?

Or perhaps it could work like mega . nz where the download starts only after you click the download button.

... but that would suck for images

speaking of which, the embedded image could be resized like on imgur and once you click it, it goes to full size. or opens in a new tab. Or whatever. edit: never mind it already gets fitted width-wise, but not height wise, which is why a tall image I tested was very hard to view.. and probably would have been hard to view if it had been fitted, too.

Just writing down anything that comes to mind.

@elrido
Copy link
Contributor

elrido commented Apr 8, 2020

The filename is of course saved and could easily be displayed. The size isn't saved, but can be retrieved from the window.Blob object the file is stored in, after decryption.

Edit: Large images are displayed scaled down to the width of the privatebin window via the CSS attribute "img-thumbnail" of bootstrap CSS. The full size is retrieved by downloading it.

@rugk
Copy link
Member

rugk commented Apr 8, 2020

Uh okay, then I've missed that. Well… then… this is technically possible in an easier way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants