Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 tests failing #1301

Open
rugk opened this issue May 4, 2024 · 2 comments
Open

PHP 8.4 tests failing #1301

rugk opened this issue May 4, 2024 · 2 comments
Labels
blocked This depends on other issue/project etc. bug code quality

Comments

@rugk
Copy link
Member

rugk commented May 4, 2024 •
edited

Tests fail due to:

We are waiting on guzzle to release a version with their PHP 8.4 fixes - it is not released yet and may still get further changes, so I assume it isn't a high prio for them. Maybe we can somehow tell github actions to run the 8.4 tests, but not mark failures there as breaking the build?

#1280 (comment)

Just an issue to track this.

Tests run: https://github.com/PrivateBin/PrivateBin/actions/runs/8949790421/job/24584480718
rugk added a commit that referenced this issue May 4, 2024
@rugk
Mark PHP v8.4 tests as experimental
55dec46 
As per this doc: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures

Workaround for #1301 for now. I hope this ignores failures?
This was referenced May 4, 2024
Closed
Closed
@rugk
Copy link
Member Author

rugk commented May 4, 2024

Also reported the issue upstream: guzzle/guzzle#3217

As per this, marking as blocked.

@rugk rugk added the blocked This depends on other issue/project etc. label May 4, 2024
@rugk
Copy link
Member Author

rugk commented May 5, 2024

FYI/PSA:

This issue has already been fixed in guzzle/guzzle#3203, and will be included in a release before PHP 8.4.0 is released.

guzzle/guzzle#3217 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This depends on other issue/project etc. bug code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rugk