Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of file picker dialog in right-to-left languages (RTL) #1251

Open
elrido opened this issue Feb 17, 2024 · 1 comment
Open

Alignment of file picker dialog in right-to-left languages (RTL) #1251

elrido opened this issue Feb 17, 2024 · 1 comment
Labels
bug i18n/l10n internationalisation/localisation UI/UX

Comments

@elrido
Copy link
Contributor

elrido commented Feb 17, 2024

Originally reported by translator Lazerns via Crowdin:

The problem

Also this should be there :)

Also this should be there :)

The solution

Ensure that the alignment matches the templates RTL mode. Bootstrap CSS should have facilities for this, we may have used the wrong CSS class.

Alternatives

Worst case, we change the alignment class based on the RTL setting PHP-side.

Additional context

Affects the two RTL translations, Arabic & Hebrew. There may be other drop downs in the menu that have similar issues.

@elrido elrido added enhancement UI/UX i18n/l10n internationalisation/localisation labels Feb 17, 2024
@rugk rugk added bug and removed enhancement labels Mar 7, 2024
@rugk
Copy link
Member

rugk commented Mar 7, 2024

Modern bootstrap seems to have some (experimental) support for it: https://getbootstrap.com/docs/5.0/getting-started/rtl/ They use https://rtlcss.com/ under-the-hood, maybe that is helpful for us too. (Also it's likely easy to migrate then, if we already use the same lib and update to bootstrap 5.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n/l10n internationalisation/localisation UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants