Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password field is not reset when clicking 'New ' #1194

Open
romed opened this issue Nov 7, 2023 · 1 comment
Open

Password field is not reset when clicking 'New ' #1194

romed opened this issue Nov 7, 2023 · 1 comment
Labels
bug good first issue Contributors could start with this easy task.

Comments

@romed
Copy link

romed commented Nov 7, 2023

Did you use the FAQ section?

  • Yes, I have read the FAQ and I found no solution/answer there.

After creating a password protected paste, clicking on 'New' returns to the creation form.
In the form the password is already prefilled with the password used for the last created paste.
Because all the other fields are defaulted when clicking on 'New', I would also assume so for the password field.

Steps to reproduce

  1. Create a password protected paste
  2. Click on 'New' to get back to the creation form
  3. Observe the password field -> It is not empty
  4. Creating the paste with the prefilled password allows to check that it is indeed the same password which was used for the first paste

What happens

Password field is not emptied when clicking on 'New'

What should happen

Password field is emptied when clicking on 'New' as are all the other input fields

Additional information

There was a similar ticket in the past: #611
It mentioned also the password not being reset, the fix did not cover it though.

Basic information

I can reproduce this issue on https://privatebin.net: Yes

@romed romed added the bug label Nov 7, 2023
@rugk
Copy link
Member

rugk commented Nov 9, 2023

Yeah, I can imagine this. Since PrivateBin is kind of a SPA, that needs to be handled in a custom way. However, it should be as simple as clearing the input at the correct position.

As such maybe a "good first issue" respectively if you want to do a PR, feel free.
We now support GitHub codespaces somewhat to have an easy start and develop directly in your browser. I have also documented this on https://github.com/PrivateBin/PrivateBin/wiki/Development#getting-started now.

@rugk rugk added the good first issue Contributors could start with this easy task. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Contributors could start with this easy task.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants