PrivateBin
1.7.2 #1308
Replies: 5 comments 11 replies
-
|
Some feedback about
Here are my personal modifications with solve all of the issues above: --- <old> Sun May 5 20:52:29 2024
+++ <new> Mon May 6 01:46:06 2024
@@ -159,48 +159,48 @@
<span class="navbar-toggler-icon"></span>
</button>
<div id="navbar" class="collapse navbar-collapse">
- <ul class="navbar-nav me-auto">
+ <ul class="navbar-nav me-auto gap-2 align-items-lg-center align-items-stretch">
<li id="loadingindicator" class="navbar-text hidden me-auto">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#clock" /></svg>
<?php echo I18n::_('Loading…'), PHP_EOL; ?>
</li>
- <li class="nav-item me-2">
- <button id="retrybutton" type="button" class="reloadlink hidden btn btn-primary">
+ <li class="nav-item d-flex flex-lg-row flex-column">
+ <button id="retrybutton" type="button" class="reloadlink hidden btn btn-primary flex-fill">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#repeat" /></svg> <?php echo I18n::_('Retry'), PHP_EOL; ?>
</button>
</li>
- <li class="nav-item">
- <button id="newbutton" type="button" class="hidden btn btn-secondary me-2">
+ <li class="nav-item d-flex gap-2 flex-lg-row flex-column">
+ <button id="newbutton" type="button" class="hidden btn btn-secondary flex-fill">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#file-earmark" /></svg> <?php echo I18n::_('New'), PHP_EOL; ?>
</button>
- <button id="clonebutton" type="button" class="hidden btn btn-secondary me-2">
+ <button id="clonebutton" type="button" class="hidden btn btn-secondary flex-fill">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#copy" /></svg> <?php echo I18n::_('Clone'), PHP_EOL; ?>
</button>
- <button id="rawtextbutton" type="button" class="hidden btn btn-secondary me-2">
+ <button id="rawtextbutton" type="button" class="hidden btn btn-secondary flex-fill">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#filetype-txt" /></svg> <?php echo I18n::_('Raw text'), PHP_EOL; ?>
</button>
- <button id="downloadtextbutton" type="button" class="hidden btn btn-secondary me-2">
+ <button id="downloadtextbutton" type="button" class="hidden btn btn-secondary flex-fill">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#download" /></svg> <?php echo I18n::_('Save paste'), PHP_EOL; ?>
</button>
<?php
if ($EMAIL) :
?>
- <button id="emaillink" type="button" class="hidden btn btn-secondary me-2">
+ <button id="emaillink" type="button" class="hidden btn btn-secondary">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#envelope" /></svg> <?php echo I18n::_('Email'), PHP_EOL; ?>
</button>
<?php
endif;
if ($QRCODE) :
?>
- <button id="qrcodelink" type="button" data-toggle="modal" data-target="#qrcodemodal" class="hidden btn btn-secondary me-2">
+ <button id="qrcodelink" type="button" data-toggle="modal" data-target="#qrcodemodal" class="hidden btn btn-secondary">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#qr-code" /></svg> <?php echo I18n::_('QR code'), PHP_EOL; ?>
</button>
<?php
endif;
?>
</li>
- <li id="expiration" class="nav-item me-2 d-flex hidden">
+ <li id="expiration" class="nav-item d-flex hidden">
<label for="pasteExpiration" class="form-label my-auto me-1"><?php echo I18n::_('Expires'); ?>:</label>
<select id="pasteExpiration" name="pasteExpiration" class="form-select">
<?php
@@ -216,7 +216,7 @@
?>
</select>
</li>
- <li class="nav-item me-2">
+ <li class="nav-item">
<div id="burnafterreadingoption" class="navbar-text form-check hidden">
<input class="form-check-input" type="checkbox" id="burnafterreading" name="burnafterreading"<?php
if ($BURNAFTERREADINGSELECTED) :
@@ -231,7 +231,7 @@
<?php
if ($DISCUSSION) :
?>
- <li class="nav-item me-2">
+ <li class="nav-item">
<div id="opendiscussionoption" class="navbar-text form-check hidden">
<input class="form-check-input" type="checkbox" id="opendiscussion" name="opendiscussion"<?php
if ($OPENDISCUSSION) :
@@ -247,8 +247,8 @@
endif;
if ($PASSWORD) :
?>
- <li class="nav-item me-2">
- <div id="password" class="navbar-form hidden">
+ <li class="nav-item">
+ <div id="password" class="navbar-form hidden d-flex">
<input type="password" id="passwordinput" placeholder="<?php echo I18n::_('Password (recommended)'); ?>" class="form-control" size="23" />
</div>
</li>
@@ -256,7 +256,7 @@
endif;
if ($FILEUPLOAD) :
?>
- <li id="attach" class="nav-item hidden dropdown me-2">
+ <li id="attach" class="nav-item hidden dropdown d-flex">
<a href="#" class="nav-link dropdown-toggle" data-bs-toggle="dropdown" role="button" aria-expanded="false"><?php echo I18n::_('Attach a file'); ?></a>
<ul class="dropdown-menu">
<li id="filewrap">
@@ -293,17 +293,11 @@
</select>
</li>
</ul>
- <ul class="navbar-nav">
- <li class="nav-item">
- <div class="form-check form-switch navbar-text">
- <input id="bd-theme" type="checkbox" class="form-check-input">
- <label for="bd-theme" class="form-check-label"><?php echo I18n::_('Dark Mode'); ?></label>
- </div>
- </li>
+ <ul class="navbar-nav flex-row-reverse gap-2">
<?php
if (!empty($LANGUAGESELECTION)) :
?>
- <li id="language" class="nav-item dropdown ms-2">
+ <li id="language" class="nav-item dropdown">
<a href="#" class="nav-link dropdown-toggle" data-bs-toggle="dropdown" role="button" aria-expanded="false">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#flag" /></svg> <?php echo $LANGUAGES[$LANGUAGESELECTION][0], PHP_EOL; ?>
</a>
@@ -324,12 +318,18 @@
<?php
endif;
?>
+ <li class="nav-item">
+ <div class="form-check form-switch navbar-text">
+ <input id="bd-theme" type="checkbox" class="form-check-input">
+ <label for="bd-theme" class="form-check-label"><?php echo I18n::_('Dark Mode'); ?></label>
+ </div>
+ </li>
</ul>
</div>
</div>
</nav>
<main>
- <section class="container mt-2">
+ <section class="container-fluid mt-2">
<?php
if (!empty($NOTICE)) :
?>
@@ -422,7 +422,7 @@
</li>
</ul>
</section>
- <section class="container">
+ <section class="container-fluid">
<article class="row">
<div id="placeholder" class="col-md-12 hidden"><?php echo I18n::_('+++ no paste text +++'); ?></div>
<div id="attachmentPreview" class="col-md-12 text-center hidden"></div>
@@ -433,22 +433,22 @@
<p class="col-md-12"><textarea id="message" name="message" cols="80" rows="25" class="form-control hidden"></textarea></p>
</article>
</section>
- <section class="container">
+ <section class="container-fluid">
<div id="discussion" class="hidden">
- <h4><?php echo I18n::_('Discussion'); ?></h4>
+ <h5><?php echo I18n::_('Discussion'); ?></h5>
<div id="commentcontainer"></div>
</div>
</section>
- <section class="container">
+ <section class="container-fluid">
<div id="noscript" role="alert" class="alert alert-info noscript-hide">
<svg width="16" height="16" fill="currentColor" aria-hidden="true"><use href="img/bootstrap-icons.svg#exclamation-circle" /></svg>
<?php echo I18n::_('Loading…'); ?><br />
<span class="small"><?php echo I18n::_('In case this message never disappears please have a look at <a href="%s">this FAQ for information to troubleshoot</a>.', 'https://github.com/PrivateBin/PrivateBin/wiki/FAQ#why-does-the-loading-message-not-go-away'); ?></span>
</div>
</section>
- <footer class="container">
+ <footer class="container-fluid">
<div class="row">
- <h4 class="col-md-5 col-xs-8"><?php echo I18n::_($NAME); ?> <small>- <?php echo I18n::_('Because ignorance is bliss'); ?></small></h4>
+ <h5 class="col-md-5 col-xs-8"><?php echo I18n::_($NAME); ?> <small>- <?php echo I18n::_('Because ignorance is bliss'); ?></small></h5>
<p class="col-md-1 col-xs-4 text-center"><?php echo $VERSION; ?></p>
<p id="aboutbox" class="col-md-6 col-xs-12">
<?php echo sprintf(--- <old> Sun May 5 20:52:29 2024
+++ <new> Sun May 5 23:01:47 2024
@@ -67,3 +67,19 @@
html[dir="rtl"] #deletelink, html[dir="rtl"] #qrcodemodalClose {
float: left;
}
+
+main {
+ padding-left: 4ch;
+ padding-right: 4ch;
+}
+
+pre {
+ background-color: #f5f5f5;
+ border: 1px solid #ccc;
+ border-radius: 4px;
+ padding: 5px;
+}
+
+ol.linenums {
+ padding-left: revert;
+} |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for sharing your observations and improvement. I'll start picking these up in a branch later this week. For the pre-elements, we may now need to put them into one of these cards to get a similar effect as in bootstrap 3. It is also annoying when sharing markdowns with code blocks, those don't stick out anymore either, so maybe using our own CSS is better after all, as long as we take care of it also working in dark mode. |
Beta Was this translation helpful? Give feedback.
-
Indeed I have forgot about this. For border, pre {
border: 1px solid var(--bs-border-color);
border-radius: 4px;
padding: 5px;
}
[data-bs-theme=light] pre {
background-color: #f5f5f5;
}
[data-bs-theme=dark] pre {
background-color: #212529;
} |
Beta Was this translation helpful? Give feedback.
-
|
Additionally, there seem to be some clash of styles with
|
Beta Was this translation helpful? Give feedback.
-
|
Also, as usual, feel free to create a PR (better small PRs focusing one one aspect), unless @elrido now says he has already incoperated/added some stuff.) |
Beta Was this translation helpful? Give feedback.
-
|
Not started yet, but good call, I'll try to raise the separate fixes as separate PR's then, so we are more flexible in discussing each and their impact. I created a project to track the different issues related to this. |
Beta Was this translation helpful? Give feedback.
-
|
With this release I can't create pastes anymore. 1.7.1 works fine, with 1.7.2 I only get an error |
Beta Was this translation helpful? Give feedback.
-
|
You can manually upgrade the schema by running these queries: ALTER TABLE "paste" DROP COLUMN "postdate";
UPDATE "config" SET "value" = '1.7.2' WHERE "id" = 'VERSION';What we would need to know to address this is a) do you get any errors running one of these queries and can you share it? b) are you using MariaDB or MySQL or another flavour and which version precisely? It may also be a permission issue, if you haven't granted the privatebin user permissions to change the schema. This is a Edit: Not allowing the privatebin database user to alter the schema is a security benefit, so generally a thing I'd recommend doing. During upgrades that could be relaxed. |
Beta Was this translation helpful? Give feedback.
-
|
I did not get any errors in the webserver logfile. I use MariaDB. The problem was probably that the privatebin user had no GRANT privileges. Dropping the column by hand fixed the problem and I have now changed permissions to include the GRANT option. |
Beta Was this translation helpful? Give feedback.
-
|
same problem here ... i created the tables new and now it works but idk why an update will "crash the database connection" |
Beta Was this translation helpful? Give feedback.
-
|
Please check the recommendation above and please also comment there regarding exact errors logged and exact RDBM and version used. |
Beta Was this translation helpful? Give feedback.
-
|
Same problem I use S3 as a backend. Works with 1.7.1 but not with 1.7.2 |
Beta Was this translation helpful? Give feedback.
-
|
Check out PrivateBin/docker-nginx-fpm-alpine#192 - we found this to be an issue in the main container image (wrong version of the AWS SDK gets selected by composer) and for now you can switch to the |
Beta Was this translation helpful? Give feedback.
-
|
Important: Please don't update to this release, it contains a critical bug! See #1309 for details. |
Beta Was this translation helpful? Give feedback.
-
shortenviayourlsin query parameters (Allow for shortenviayourls in query params #1267)template = "bootstrap5"to switch to it (Upgrade Bootstrap to v4 or higher #728)langcookie with laxSameSitepropertycreateattribute is no longer returned in API for pastes & can be disabled for comments usingdiscussiondatedisplayas well (Discrepancy between API (docs) and behaviour of privatebin.net regarding comments #1290)Note regarding the new template "bootstrap5", that if you want the button icons (SVG) to display, you have to relax the CSP rule slightly and change default-src from
'none'to'self'. You configure it as follows:The new theme comes in only one flavour, but does include a dark-mode switch and attempts detecting the currently set browser preference.
We don't yet enable this new template by default. Please report any issues you find with it or submit pull requests with your improvements. Should no major issues get detected, we intend to make it the new default later this year and eventually deprecate and remove the old bootstrap 3 templates, as well as the page (classic ZereBin) one. It would be appreciated if additional templates would get submitted and shared with the community, so we get some more variety to choose from.
This discussion was created from the release 1.7.2.
Beta Was this translation helpful? Give feedback.
All reactions