Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly decoding after sections (bedrock) #229

Open
Flonja opened this issue Aug 13, 2023 · 1 comment
Open

Incorrectly decoding after sections (bedrock) #229

Flonja opened this issue Aug 13, 2023 · 1 comment

Comments

@Flonja
Copy link
Contributor

Flonja commented Aug 13, 2023

When sub chunks have been read properly border blocks, biomes and (possible) block entities follow.
Though when a server only uses LevelChunkPackets, it can still send 1.18-type biomes, (unless the vanilla_version field is 1.17.40 or lower.)

This edge-case can be reproduced on a PMMP4 server, (as this doesn't use the mode -1 or -2.)

From (prismarine-chunk/1.18/ChunkColumn L145) to the incorrect code block: prismarine-chunk/1.3/ChunkColumn (L189-L191).
What it should be could be found in the previous implementation: bedrock-provider/1.3/ChunkColumn.ts (L352-L363).

Flonja added a commit to Flonja/prismarine-chunk that referenced this issue Aug 13, 2023
rom1504 pushed a commit that referenced this issue Aug 21, 2023
@Flonja
Copy link
Contributor Author

Flonja commented Apr 23, 2024

Can't remember if this got fixed or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant