Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block entity support #134

Open
rom1504 opened this issue Aug 8, 2021 · 5 comments
Open

Block entity support #134

rom1504 opened this issue Aug 8, 2021 · 5 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Aug 8, 2021

No description provided.

@rom1504
Copy link
Member Author

rom1504 commented Aug 14, 2021

I don't remember the last status, but I think this was almost done by @u9g

@rom1504
Copy link
Member Author

rom1504 commented Dec 31, 2021

#113

@rom1504
Copy link
Member Author

rom1504 commented Dec 31, 2021

#102

@rom1504
Copy link
Member Author

rom1504 commented Dec 31, 2021

The name of the property should be the same as the one created by mineflayer block at

Dump and load should put in internal storage
And get/set block should get/put in internal storage

@extremeheat
Copy link
Member

#162 adds block entity read/writing for anvil provider through the .entity property. I don’t think .blockEntity can be used (like in mineflayer) since it returns simplified NBT data, which can’t be written back to disk later on. So to keep things api compatible both .entity and blockEntity could exist, the former being the un-simplified NBT and the latter being simplified (.blockEntity can be a getter to nbt.simplify(block.entity))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants