Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prismarine-registry #613

Open
rom1504 opened this issue Oct 12, 2022 · 5 comments
Open

Use prismarine-registry #613

rom1504 opened this issue Oct 12, 2022 · 5 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2022

No description provided.

@rom1504
Copy link
Member Author

rom1504 commented Jan 6, 2024

It's used now but maybe should be instantiated by server x version

@Pandapip1
Copy link
Contributor

Probably worth closing this issue and making a new one then?

@rom1504
Copy link
Member Author

rom1504 commented Jan 7, 2024

No it's still valid

@Pandapip1
Copy link
Contributor

No it's still valid

Okay. Is there any advantage to using a single instance? What if the server is multi-version; wouldn't it make sense for per-client plugins to use a registry instance that uses the player version, not the union of the server versions?

@rom1504
Copy link
Member Author

rom1504 commented Jan 8, 2024

The version/player consideration is independent from the consideration of having the registry be stateful or not.

The benefit of having the registry be stateful is the ability to change the parameters sent to all clients, for example by loading a config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants