Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ode: the guesser logic is partially wrong #635

Open
fnrizzi opened this issue Aug 31, 2023 · 0 comments
Open

ode: the guesser logic is partially wrong #635

fnrizzi opened this issue Aug 31, 2023 · 0 comments

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Aug 31, 2023

the guess callback is not being called before the stpper executes a step.
this is correct as far as the predicted state, but it is wrong for the history because internally the stepper updates the history so the previous state is now being copied to be equal to the guess which is wrong. the guess should not impact the history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: todo (uncategorized)
Development

No branches or pull requests

1 participant