Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ode: handling compatiblity of ind var type and scalar types of operators #401

Open
fnrizzi opened this issue Aug 31, 2022 · 0 comments
Open

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Aug 31, 2022

we currently require:

    && std::is_convertible<
      typename T::independent_variable_type,
      typename ::pressio::Traits<typename T::state_type>::scalar_type
      >::value

and inside we work with scalar_type but i think we should use std::common_t if possible and overall assess how to handle this better.
The main issue comes if one wants to use say a custom time type that has, e.g., a builtin unit.

@fnrizzi fnrizzi changed the title ode: need to carefully look at properly handling compatiblity of ind var type and scalar types of operators ode: look how to properly handling compatiblity of ind var type and scalar types of operators Aug 31, 2022
@fnrizzi fnrizzi changed the title ode: look how to properly handling compatiblity of ind var type and scalar types of operators ode: handling compatiblity of ind var type and scalar types of operators Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant