Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrowing in UI select menus #1053

Open
brandonreid opened this issue Dec 13, 2023 · 1 comment
Open

Fix arrowing in UI select menus #1053

brandonreid opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request low

Comments

@brandonreid
Copy link
Contributor

When opening a select menu there are a few basic improvements we should make:

  1. Currently when opening the menu, you can arrow down and highlight options, once you hit the bottom, it doesn't loop back to the top, but it should.
  2. When opening the menu, you can arrow up immediately and the last option will highlight, allowing you to arrow up from there, when you get to the top you aren't brought back to the bottom when continuing to arrow up.
  3. When arrowing out of view, the popup should scroll so you can see the highlighted option.
Screen.Recording.2023-12-13.at.5.34.51.PM.mov
@brandonreid brandonreid added enhancement New feature or request low labels Dec 13, 2023
@pleek91
Copy link
Collaborator

pleek91 commented Dec 13, 2023

For 1 that's not how browser's implementation works which we've tried to follow. If you use the native select in this demo you'll see that arrowing up at the top does not loop back to the bottom neither does arrowing down from the bottom loop you back to the top. Do you fee strongly about this?

For 2 I think we just need to default highlight the first option when it opens and that would fix that.

3 is for sure an issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

2 participants