Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

characters in a @label #2120

Open
Alex-Jordan opened this issue Feb 1, 2024 · 0 comments
Open

characters in a @label #2120

Alex-Jordan opened this issue Feb 1, 2024 · 0 comments

Comments

@Alex-Jordan
Copy link
Contributor

For example, this label on an image is no good at present: label="graph-of-y=1/2x". The slash is a problem when the label is used in a filename for obvious reasons. The equals sign is apparently potentially problematic in a file name in Windows.

Two solutions occur to me:

  1. We sanitize labels when making things like file names. You end up with files like graph-of-y__equals__1__slash__2x.png.
  2. We restrict the characters that are used in an authored label in the first place. In assembly, where label duplication is checked, that would be a natural place to check that only approved characters are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant