Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generify Repository Name #11

Open
rlipperts opened this issue Dec 22, 2020 · 6 comments
Open

Generify Repository Name #11

rlipperts opened this issue Dec 22, 2020 · 6 comments

Comments

@rlipperts
Copy link
Contributor

rlipperts commented Dec 22, 2020

When looking for a Polybar plugin to control music playback in chrome with, I scrolled across this multiple times without opening it. The naming suggests that this only works with Spotify, while your code actually is quite generic.

Wouldn't it be good to change the repository name to something like polybar-playerctl? Furthermore, the names of example modules in the readme (and in the hooks in get_spotify_status.sh) would need to be updated.

Edit: Just noticed you mentioned this in one of your commits. I think you should :)

@stale
Copy link

stale bot commented Dec 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 29, 2020
@stale stale bot closed this as completed Jan 5, 2021
@PrayagS
Copy link
Owner

PrayagS commented Jan 7, 2021

I'm really sorry that I wasn't able to attend to this issue. I agree that most of the traffic comes from Google searches and just renaming should maintain the traffic. However, I think I'll rename it when I've added a bit more features to the module and post it like a new release.

And hence, please keep opening issues for new features. Currently, I'm a little busy but I assure you I'll get back to this issue soon.

@PrayagS PrayagS reopened this Jan 7, 2021
@stale stale bot removed the stale label Jan 7, 2021
@rlipperts
Copy link
Contributor Author

rlipperts commented Jan 7, 2021

No Problem. We all have limited time for this (sadly)

@fuadsaud
Copy link

fuadsaud commented Jan 7, 2021

I have been using a modified version of this repo in such a way that it's not specific to spotify. It assumes playerctld is running.

However, there's a bug to which I haven't been able to figure out a solution:

Steps to reproduce

  1. Play player A
  2. Play player B (both players will be playing at the same time)
  3. Pause player c

Expected behavior

  • Play/pause icon should be ⏸️
  • Metadata about player A should be displayed

Actual behavior

  • Play/pause icon is ▶️
  • Metadata about player B is displayed

I tried to fix this by using playerctl's --follow flag but without success. I'm still trying to play with it to find a solution.

@PrayagS
Copy link
Owner

PrayagS commented Jan 8, 2021

@fuadsaud Can you please open a separate issue?

@ulises-jeremias
Copy link

@fuadsaud @PrayagS any update on this? would love to make this module as part of my dotfiles generator once it supports more than spotify 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants