New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Quality] Add Type Hinting #74

Open

scarf005 opened this issue Jan 24, 2023 · 1 comment

Labels

enhancement good first issue

Contributor

scarf005 commented Jan 24, 2023 •

edited

Is your feature request related to a problem? Please describe.
adding type hint will make developing konsave much easier.

Describe the solution you'd like

add type hint to project code
use pydantic or msgspec to validate and generate JSON schema for config file

Additional context
willing to create a PR for it.

Owner

Prayag2 commented Jan 30, 2023

willing to create a PR for it.

Please feel free to make a PR :)

Prayag2 added the enhancement label

Prayag2 changed the title ~~type hint konsave~~ [CODE QUALITY] Add Type Hinting

Prayag2 changed the title ~~[CODE QUALITY] Add Type Hinting~~ [Code Quality] Add Type Hinting

Prayag2 added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment