Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement of StatementList parsing #10

Open
Shachar opened this issue Dec 13, 2019 · 1 comment
Open

Performance improvement of StatementList parsing #10

Shachar opened this issue Dec 13, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Shachar
Copy link
Collaborator

Shachar commented Dec 13, 2019

When parsing StatementList followed by an expression, the last expression may be parsed twice. Once as part of the StatementList, and another time on its own.
@Shachar Shachar added enhancement New feature or request good first issue Good for newcomers labels Dec 13, 2019
@Shachar
Copy link
Collaborator Author

Shachar commented Dec 13, 2019

One way to solve this is to parse using an ExpressionOrStatement parser, and then return the last Expression as an out variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shachar