Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG in ssh-shellhost.exe #2186

Open
3 tasks done
abakum opened this issue Dec 2, 2023 · 8 comments
Open
3 tasks done

BUG in ssh-shellhost.exe #2186

abakum opened this issue Dec 2, 2023 · 8 comments

Comments

@abakum
Copy link

abakum commented Dec 2, 2023

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest version
  • Search the existing issues.

Steps to reproduce

Server side-------------------
C:\Program Files\OpenSSH>"C:\Program Files\OpenSSH"sshd -ddd
...
debug1: sshd version OpenSSH_for_Windows_9.4, LibreSSL 3.7.3
...
debug3: shell: "c:\\windows\\system32\\cmd.exe"
debug3: shell_option: /c
debug3: couldn't find CreatePseudoConsole() in kernel32.dll dll
debug3: This windows OS doesn't support conpty
debug3: pty commandline: "C:\\Program Files\\OpenSSH\\ssh-shellhost.exe" ---pty "c:\\windows\\system32\\cmd.exe"

Client side----------------------------------
mode con cols=80 lines=9999
ssh -vvv Konstantin.Abakumov@127.0.0.1
...
debug1: Local version string SSH-2.0-OpenSSH_for_Windows_9.4
debug1: Remote protocol version 2.0, remote software version OpenSSH_for_Windows_9.4
...
debug3: client_repledge: enter
debug1: ENABLE_VIRTUAL_TERMINAL_INPUT is supported. Reading the VTSequence from console
debug3: couldn't find CreatePseudoConsole() in kernel32.dll dll
debug3: This windows OS doesn't support conpty
debug1: ENABLE_VIRTUAL_TERMINAL_PROCESSING is supported. Console supports the ansi parsing
....

uf\konstantin.abakumov@WUFRS0661151 C:\Users\user>mode con

Состояние устройства CON:

Строки:                9999
Столбцы:               80
Скорость клавиатуры:   31
Задержка клавиатуры:   1
Кодовая страница:      866

------------------------------------ ssh-shellhost.exe work well on start-----------------------------------------------

------------------------------------I enlarge width of console-----------------------------------------------

Client side----------------------------------
debug2: client_check_window_change: changed
debug2: channel 0: request window-change confirm 0
debug3: send packet: type 98
debug2: client_check_window_change: changed
debug2: channel 0: request window-change confirm 0
debug3: send packet: type 98
debug2: client_check_window_change: changed
debug2: channel 0: request window-change confirm 0
debug3: send packet: type 98
debug2: client_check_window_change: changed
debug2: channel 0: request window-change confirm 0
debug3: send packet: type 98

Server side-------------------
debug3: receive packet: type 98
debug1: server_input_channel_req: channel 0 request window-change reply 0
debug1: session_by_channel: session 0 channel 0
debug1: session_input_channel_req: session 0 req window-change
debug3: receive packet: type 98
debug1: server_input_channel_req: channel 0 request window-change reply 0
debug1: session_by_channel: session 0 channel 0
debug1: session_input_channel_req: session 0 req window-change

Client side----------------------------------
uf\konstantin.abakumov@WUFRS0661151 C:\Users\user>mode con

Состояние устройства CON:

Строки:                9999
Столбцы:               80
Скорость клавиатуры:   31
Задержка клавиатуры:   1
Кодовая страница:      866

------------------------------------Nothing happend!!! BUG in ssh-shellhost.exe -----------------------------------------------

exit
------------------------------------End session-----------------------------------------------
------------------------------------New session with same console-----------------------------------------------

ssh Konstantin.Abakumov@127.0.0.1
uf\konstantin.abakumov@WUFRS0661151 C:\Users\user>mode con

Состояние устройства CON:

Строки:                9999
Столбцы:               102
Скорость клавиатуры:   31
Задержка клавиатуры:   1
Кодовая страница:      866    

------------------------------------ ssh-shellhost.exe work well on start-----------------------------------------------

Expected behavior

After enlarge width of console
Columns:               102

Actual behavior

Columns:               80

Error details

The width of the console on the server side does not change

Environment data

Name                           Value
----                           -----
PSVersion                      5.1.14393.5582
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.5582
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Version

OpenSSH_for_Windows_9.4, LibreSSL 3.7.3

Visuals

No response

@abakum
Copy link
Author

abakum commented Dec 3, 2023

Please uncoment https://github.com/PowerShell/openssh-portable/blob/4ee8dc64982b62cd520417556515383908091b76/contrib/win32/win32compat/shell-host.c#L804. To fix:

>2) when ssh client window is resized it clears everything and gives a blank screen.

@abakum
Copy link
Author

abakum commented Dec 3, 2023

For me ssh-shellhost.exe for amd64 from #1222 (comment) works well. Were can I find ssh-shellhost.exe for 386?

@maertendMSFT
Copy link
Collaborator

@abakum what OS versions do you have running on the client and the server?

@abakum
Copy link
Author

abakum commented Dec 4, 2023

Microsoft Windows [Version 10.0.14393]
on same PC server and client

@tgauth
Copy link
Collaborator

tgauth commented Dec 4, 2023

Starting with Windows 10 Build 18309, ConPTY should be supported so ssh-shellhost is not needed. Is updating the OS an option?

Also, all releases have 386 binaries within OpenSSH-Win32.zip

@abakum
Copy link
Author

abakum commented Dec 4, 2023

VScode used winpty

@tgauth
Copy link
Collaborator

tgauth commented Dec 4, 2023

Are you running SSH through the VSCode extension?

@abakum
Copy link
Author

abakum commented Dec 4, 2023

No, but VSCode does not offer to update the Windows version - it just uses what works \8^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants