Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation renders twice when swiping in safari #159

Open
1 of 8 tasks
rubenstolk opened this issue Dec 27, 2016 · 1 comment
Open
1 of 8 tasks

Animation renders twice when swiping in safari #159

rubenstolk opened this issue Dec 27, 2016 · 1 comment

Comments

@rubenstolk
Copy link

rubenstolk commented Dec 27, 2016

Description

When swiping the bar in our out, and then "letting it go", the animation restarts.

Issue only applies to v1.0.11

Expected outcome

The animation to continue swiping in or out.

Actual outcome

The animation restarts from the beginning.

Live Demo

Steps to reproduce

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@t-soares
Copy link
Contributor

The PR #158 introduced a regression on this component. The PR #158 changed the drawer opening and closing to be done inside a requestAnimationFrame. At the end of a swipe movement, the width is reset outside the rAF block, causing the opening/closing animation to be started from the initial position.

t-soares pushed a commit to t-soares/paper-drawer-panel that referenced this issue Dec 28, 2016
t-soares added a commit to t-soares/paper-drawer-panel that referenced this issue Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants