Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One test failure in Chrome: test/multi.html » multi » updates selection when dom changes #86

Open
cdata opened this issue Nov 20, 2015 · 2 comments
Open

One test failure in Chrome: test/multi.html » multi » updates selection when dom changes #86

cdata opened this issue Nov 20, 2015 · 2 comments
Labels
good-first-bug help wanted p1 - backlog

Comments

@cdata
Copy link
Contributor

cdata commented Nov 20, 2015

This error started occurring with the addition of ShadowDOM-specific tests.
@cdata cdata mentioned this issue Nov 20, 2015
Merged
@reinert
Copy link
Contributor

reinert commented Nov 20, 2015

maybe related to #75?

bicknellr added a commit that referenced this issue Jan 5, 2016
@bicknellr
Fixes #86: Deselects nodes which are no longer items after items change.
5ecd3eb
@bicknellr
Copy link
Contributor

The MutationObserver that Polymer.Base.async uses to queue microtasks is added earlier than the one that the iron-selector uses to monitor its children, so it ends up getting called first: adding a 1ms delay to the last async call in that test (causing it to use setTimeout) makes it pass. (JSBin showing this behavior.)

invokeLast strikes again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-bug help wanted p1 - backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdata @bicknellr @reinert