Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@demo path should be relative to source file, not component page. #114

Open
MaKleSoft opened this issue Dec 6, 2016 · 0 comments
Open

Comments

@MaKleSoft
Copy link

Currently it seems that iron-component-page expects the link provided through the @demo tag is relative to the component page. This is problematic for several reasons:

  • Its counterintuitive. Data point of one, but I would expect the link to be relative to the source file.
  • The element can't be included in multiple component pages at once.
  • When analyzing the file individually, one has to know the location of the component page in order to determine the location of the demo page. In fact, without the existence of a component page, the demo path is not well-defined. This is relevant for other analytics tools like polylint.

To ensure backward compatibility, iron-component-page could try to resolve the demo path both relative to the component page and relative to the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant