Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch is hard-coded #101

Open
8 tasks done
tomalec opened this issue Jun 7, 2016 · 1 comment
Open
8 tasks done

master branch is hard-coded #101

tomalec opened this issue Jun 7, 2016 · 1 comment

Comments

@tomalec
Copy link
Contributor

tomalec commented Jun 7, 2016

Description

iron-component-page has "master" branch name hard-coded therefore it's impossible to use it with any other branch.

Expected outcome

iron-component-page should be able to render component page regardless of branch name

Actual outcome

No documentation found.

is shown

Live Demo

http://puppetjs.github.io/puppet-polymer-client/

Steps to reproduce

  1. Create custom-element as any other.
  2. Use branch anything.
  3. Open http://yourorganization.github.io/custom-element/.

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@tomalec
Copy link
Contributor Author

tomalec commented Jun 28, 2016

@justinfagnani Could you take a look?
All checks are passing for PR #102.
I think the fix is quite non-intrusive.
But issue makes iron-component-page useless to quite many (at least our) custom elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant