Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<app-navigation> #261

Open
JosefJezek opened this issue Jul 2, 2016 · 2 comments
Open

<app-navigation> #261

JosefJezek opened this issue Jul 2, 2016 · 2 comments

Comments

@JosefJezek
Copy link

Could you create new element <app-navigation>? Here is Material Design specification...

https://material.google.com/components/bottom-navigation.html

Left navigation on a larger display, such as tablet or desktop with enhancement from site https://console.cloud.google.com

https://material.google.com/components/bottom-navigation.html#bottom-navigation-usage

image

image

@blasten
Copy link
Contributor

blasten commented Jul 11, 2016

+1 I think we should have those elements in app-layout. Wdyt @frankiefu @keanulee ?

Related issue: #20

@samthecodingman
Copy link

I encountered this problem the other day and built my own element for the bottom navigation component and named it app-bottom-nav. Apart from trouble with assigning CSS Custom Properties (it works, but only when using a * {...} CSS selector.) I intend to work on the app-side-nav to complement it soon. Surprisingly, I got the animations described by the spec to work too - however on really thin viewports it animates a little strange.

WebComponents Link

Personally I also think that having an app-navigation element that handles both the side and bottom navigations would simply be annoying if also working with an app-drawer. Which is why I plan to keep them as separate elements and then maybe have a parent "group" element that just adds the app-side-nav and app-bottom-nav into the DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants