Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

polymer 2.0 upgrade guide fire equivalent missing cancellable #2641

Open
davidmaxwaterman opened this issue Jun 29, 2018 · 1 comment
Open

Comments

@davidmaxwaterman
Copy link
Contributor

IINM, the polymer fire() method also sets the cancellable flag to true. This tripped me up in a recent upgrade since the code was testing defaultPrevented which was always false, even though preventDefault() had been called.

@ghost
Copy link

ghost commented Jul 24, 2018

API docs say that the default for cancelable in the fire method is false https://www.polymer-project.org/1.0/docs/api/#method-fire ... this matches up with the Web API defaults for Event and CustomEvent as far as i can work out. I'm curious what caused you to think cancelable gets set to true? If you can point it out in the docs or give a code sample I will try to clear up any confusion, or raise a bug if needed :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant