Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polymath-core's artifacts on production #53

Open
RafaelVidaurre opened this issue Oct 1, 2018 · 0 comments
Open

Use polymath-core's artifacts on production #53

RafaelVidaurre opened this issue Oct 1, 2018 · 0 comments
Labels
bug Something isn't working Github For Asana integration use only

Comments

@RafaelVidaurre
Copy link
Contributor

RafaelVidaurre commented Oct 1, 2018

Since we are emulating a fixed state with local copies of the JSON artifacts in development, this needs to be considered for production builds, where we will want to load polymath-core's artifacts.

This should consider the fact that E2E tests connect to ganache instead of Kovan or the Mainnet. Meaning this behavior should continue for them.

What needs to be done:

  • On production builds point to polymath-core's artifacts instead of polymath-shared's fixtures
  • On e2e continue pointing to shared instead of polymath-core

This can be done by either changing where the dependencies point to or having polymath-shared provide the polymath-core contracts when built for production

@RafaelVidaurre RafaelVidaurre added bug Something isn't working Github For Asana integration use only labels Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Github For Asana integration use only
Projects
None yet
Development

No branches or pull requests

1 participant