Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TradingFeesBurned event is being used for all fees regardless if they are burned or not #941

Open
jaymansfield opened this issue Apr 9, 2024 · 0 comments
Open

TradingFeesBurned event is being used for all fees regardless if they are burned or not #941

jaymansfield opened this issue Apr 9, 2024 · 0 comments
Assignees
@zktony
Labels
bug Something isn't working un-confirmed Issue is not confirmed by Polkadex team

Comments

@jaymansfield
Copy link
Contributor

jaymansfield commented Apr 9, 2024 •
edited

Currently the system is only burning the PDEX collected as fees, but it is still using the TradingFeesBurned event for all other assets collected as well.

Example:
Screen Shot 2024-04-09 at 9 33 22 AM

But this was not burned, it was moved to the fee wallet.

Suggesting to create a new event to differentiate between trading fees collected and trading fees burned.
@jaymansfield jaymansfield added bug Something isn't working un-confirmed Issue is not confirmed by Polkadex team labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zktony zktony

Labels
bug Something isn't working un-confirmed Issue is not confirmed by Polkadex team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaymansfield @zktony