Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only adds or formula in household_benefits #808

Open
MaxGhenis opened this issue Feb 6, 2024 · 3 comments
Open

Keep only adds or formula in household_benefits #808

MaxGhenis opened this issue Feb 6, 2024 · 3 comments

Comments

@MaxGhenis
Copy link
Collaborator

As required by new policyengine-core, this has a formula and adds

@anth-volk
Copy link
Contributor

Also

class household_tax(Variable):

@MaxGhenis
Copy link
Collaborator Author

Let's use adds and reforms as needed. Switching to a formula would result in it not decomposing in the app. See PolicyEngine/policyengine-us#3851

@MaxGhenis
Copy link
Collaborator Author

See PolicyEngine/policyengine-us#3972 for an example of a PR that applies reforms for these conditional lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants