New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hard-coded removal of special characters in historical_report_purge() #2

Open

ablaette opened this issue Mar 12, 2024 · 0 comments

ablaette commented Mar 12, 2024

We have relaxed the regex for data cleaning successively. Now we have these steps in historical_report_purge():

  data[["Message"]] <- gsub("\\&", "+", data[["Message"]])
  data[["Message"]] <- gsub("<", "", data[["Message"]])
  data[["Message"]] <- gsub(">", "", data[["Message"]])
  data[["Message"]] <- gsub("[^-0-9a-zA-ZäöüÄÖÜß\\.,!\\?:;#/ ]+", "", data[["Message"]])

It would be better to have a arguments/options rather than this hard-coded approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment