Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type name icons #137

Closed
gabeklavans opened this issue Mar 2, 2024 · 8 comments
Closed

Add type name icons #137

gabeklavans opened this issue Mar 2, 2024 · 8 comments

Comments

@gabeklavans
Copy link
Contributor

I would love to be able to use PokeAPI to fetch the type name icon sprites from a specific generation.

They could be returned as a property of a type object.

The most succinct list I can find of them right now is on bulbapedia.

@FallenDeity
Copy link
Contributor

Hmm we could have it under type object as

"icons": {
    "generation-i": {
          "game": {
               "symbol": "",
               "name_icon": ""
            }
      }
}

Maybe something for a tera type too ig

@Naramsim
Copy link
Member

I'd use sprites instead of icons

@FallenDeity
Copy link
Contributor

Fair I'll try and work on this once my exams are over

@gabeklavans
Copy link
Contributor Author

gabeklavans commented Mar 19, 2024

I can dump the sprites here in the meantime, if that would help. Where would they go

@Naramsim
Copy link
Member

I'd put them here: https://github.com/PokeAPI/sprites/tree/master/sprites in a new folder types

@FallenDeity
Copy link
Contributor

Yeah sure u can zip them up and dump it helps if u categorise it folder wise too for certain types or games, upto you

@gabeklavans
Copy link
Contributor Author

if u categorise it folder wise too for certain types or games, upto you

I'm thinking I'll categorize by game, matching how bulbapedia does it

@gabeklavans
Copy link
Contributor Author

Moving tracking for this over to PokeAPI/pokeapi#1066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants