Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhance the CI publishing section #57

Open
DahanDv opened this issue Dec 18, 2023 · 3 comments
Open

Inhance the CI publishing section #57

DahanDv opened this issue Dec 18, 2023 · 3 comments

Comments

@DahanDv
Copy link
Contributor

DahanDv commented Dec 18, 2023

@Naramsim Hi there.
Once you guys figure out the Pypi bureaucracy,
I'd like to propose changing the CI and automating the publishing process.

The CI will be split to 2 scenarios:

  1. Push. Any push to any branch will trigger all the testing suites. Same goes for non-master PRs.
  2. when a PR gets merged into master and only into master an automatic process will bump the version and execute the Pypi publish command.

Let me know if this sounds, and if it is, when we can start work on to :)

@Naramsim
Copy link
Member

Hi! @GregHilmes added the pokeapi account to his package, so I was able to publish 1.4.0, then 1.4.1 as well :)

We are ready! We can add a token in the secrets for publishing

@DahanDv
Copy link
Contributor Author

DahanDv commented Dec 21, 2023

@Naramsim
Great!
I admit this will be the first time I'll implement such a process on GitHub's action platform, so it may take a few days to figure out, give or take, depending on other occupations I have. Let's keep this issue as a thread if I need anything from you guys :)

@Naramsim
Copy link
Member

Okok It'll be a learning experience!

I'll give you a thorough review 😁😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants