Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Move_Effect in API #1071

Open
GreatNovaDragon opened this issue Apr 25, 2024 · 2 comments
Open

Expose Move_Effect in API #1071

GreatNovaDragon opened this issue Apr 25, 2024 · 2 comments

Comments

@GreatNovaDragon
Copy link
Contributor

It would be kinda interessting for data research (at least for me), to expose the Move_Effect table in API.

I have an issue in my code, where apparently the short_effect of multiple Move_Effects is the same, compared to their long_effect, (ignoring that all of them in the change for #1031 now have the move effect chance in there), so i cant just group by the effect prose when looping over the list of moves to get.

Knowing that there are 1k moves, but only ~400 move effects, makes me wanna know what the most used move_effects are overall. (Count how many pokemon knows a move, then group by move_effect, and do some filtering on the moves if needed).

@Naramsim
Copy link
Member

Naramsim commented May 2, 2024

Would you be able to create an endpoint and try exposing it by yourself? We don't have time or we need a volunteer :)

@GreatNovaDragon
Copy link
Contributor Author

I am kinda aware that there arent many contributers, in comparision to users, so I am opening Feature Requests to gather feedback before i do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants